Modify the sample code in the Location hash property
#37022
Conversation
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2025-01-07 18:26:42) |
| console.log(anchor.hash); // '#examples' | ||
| </script> | ||
| ```js | ||
| // https://developer.mozilla.org/en-US/docs/Web/API/Location/hash#examples |
There was a problem hiding this comment.
I think we'd better to describe something like the following: assume we've navigated to some-url
There was a problem hiding this comment.
Agree that this would be clearer.
| @@ -18,12 +18,9 @@ A string. | |||
|
|
|||
There was a problem hiding this comment.
The description above is not correct, see: #37003. We may also fix the issue here.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for your PR! I agree with @yin1999 's comment in #37022 (comment).
I also agree with https://github.com/mdn/content/pull/37022/files#r1863057686 - we could fix an issue in this PR as well. But that's optional really since it is unrelated.
I apologize for not addressing the issue in a timely manner, now here's how I'm going to fix it |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Description
Related issues and pull requests